[kepler-dev] [Bug 5266] Two empty boxes inside Sinewave actor and other icon problems for attributes

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266

Daniel Crawl <crawl at sdsc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|crawl at sdsc.edu              |cxh at eecs.berkeley.edu
            Summary|Two empty boxes inside      |Two empty boxes inside
                   |Sinewave actor when in      |Sinewave actor and other
                   |Reporting suite             |icon problems for
                   |                            |attributes

--- Comment #18 from Daniel Crawl <crawl at sdsc.edu> ---
The change to ValueIcon.java in r64716 was reverted, leaving ShowTypes and
MonitorReceiverContents with titles. The documentation for ValueIcon describes
it as: "An icon that displays a bullet, the name, and, ... its value." These
attributes should not be displayed as bullets, so I changed the _icon class
from ValueIcon to XMLIcon in these attributes' XML files in
actors/resources/kar/CoreActors/, and they are now displayed correctly.

MonitorManager also had a title. I fixed this by adding a _hideName attribute
in its constructor.

I updated ComponentEntityConfig to not use the default green box icon for
attributes. This fixed the author attribute in the MatlabExpression demo and
the "Generate a sine wave" attribute in the Sinewave actor.

The "Documentation" attribute in Sinewave was still not displayed, which was
due to the SVG x and y having negative values. Batik does not appear to render
icons with negative x and y.

Kepler uses batik for SVG, but Ptolemy does not. As far as I can tell, all
Kepler icons have positive x and y, and most Ptolemy icons have negative x and
y. Conveniently, there are no attributes other than directors with
Kepler-specific icons, so I changed KeplerXMLIcon to use diva instead of batik
to render attributes. If Kepler icons are created for attributes in the future,
we'll need to find a better solution.

As far as I can tell, all the icon problems are now fixed; reassigning to
Christopher to test.

By the way, it appears that diva.util.java2d.svg.SVGPaintedObject is only
referenced by Kepler, and is the only Ptolemy class using the batik jar...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nceas.ucsb.edu/kepler/pipermail/kepler-dev/attachments/20121130/bfaa8166/attachment.html>