<html>
<head>
<base href="http://bugzilla.ecoinformatics.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:crawl@sdsc.edu" title="Daniel Crawl <crawl@sdsc.edu>"> <span class="fn">Daniel Crawl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Two empty boxes inside Sinewave actor and other icon problems for attributes"
href="http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266">bug 5266</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>crawl@sdsc.edu
</td>
<td>cxh@eecs.berkeley.edu
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>Two empty boxes inside Sinewave actor when in Reporting suite
</td>
<td>Two empty boxes inside Sinewave actor and other icon problems for attributes
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Two empty boxes inside Sinewave actor and other icon problems for attributes"
href="http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Two empty boxes inside Sinewave actor and other icon problems for attributes"
href="http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266">bug 5266</a>
from <span class="vcard"><a class="email" href="mailto:crawl@sdsc.edu" title="Daniel Crawl <crawl@sdsc.edu>"> <span class="fn">Daniel Crawl</span></a>
</span></b>
<pre>The change to ValueIcon.java in r64716 was reverted, leaving ShowTypes and
MonitorReceiverContents with titles. The documentation for ValueIcon describes
it as: "An icon that displays a bullet, the name, and, ... its value." These
attributes should not be displayed as bullets, so I changed the _icon class
from ValueIcon to XMLIcon in these attributes' XML files in
actors/resources/kar/CoreActors/, and they are now displayed correctly.
MonitorManager also had a title. I fixed this by adding a _hideName attribute
in its constructor.
I updated ComponentEntityConfig to not use the default green box icon for
attributes. This fixed the author attribute in the MatlabExpression demo and
the "Generate a sine wave" attribute in the Sinewave actor.
The "Documentation" attribute in Sinewave was still not displayed, which was
due to the SVG x and y having negative values. Batik does not appear to render
icons with negative x and y.
Kepler uses batik for SVG, but Ptolemy does not. As far as I can tell, all
Kepler icons have positive x and y, and most Ptolemy icons have negative x and
y. Conveniently, there are no attributes other than directors with
Kepler-specific icons, so I changed KeplerXMLIcon to use diva instead of batik
to render attributes. If Kepler icons are created for attributes in the future,
we'll need to find a better solution.
As far as I can tell, all the icon problems are now fixed; reassigning to
Christopher to test.
By the way, it appears that diva.util.java2d.svg.SVGPaintedObject is only
referenced by Kepler, and is the only Ptolemy class using the batik jar...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>