[kepler-dev] [Bug 5017] ReportLayout LSID and referral list should be maintained

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5017

--- Comment #15 from debi staggs <staggs at nceas.ucsb.edu> 2010-06-21 15:06:43 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (In reply to comment #11)
> > > > Sounds good. Can you poke around looking for any other similar problems -- e.g.
> > > > what happens when you have multiple copies of the same report open (same LSID),
> > > > make changes to one, but switch to the original window and execute that
> > > > workflow? There exist in the system at that moment two report layouts with the
> > > > same LSID. Hopefully the right report is used 
> > 
> > I gave the above a try, and what I found (by looking at the generated report)
> > is that the wrong layout is used (the other window's layout--the one modified
> > by user-- is used).
> > 
> > >> and has its LSID incremented, and
> > > > hopefully the other report doesn't lose its changes, will have it's LSID
> > > > incremented and be saved to prov when that wf is run, etc.
> > > 
> > > After testing I have found that what happens in this case, is that when you
> > > open two copies of the same workflow, select one of them, make changes to one,
> > > then switch to the original window and execute that workflow, then the LSID for
> > > the report layout is incremented at that point.  There are no longer 'two'
> > > report layouts. There is one current layout, and one layout that has (in
> > > essence) been changed (by running the workflow) but not saved.  If you switch
> > > to the workflow in either window they will both show the same LSID for the
> > > report layout.  
> > 
> > How are you looking at the report layout here? I'm confused.
> > 
> > > If you go to that window where the first change was made it
> > > will always reload the layout from the workflow no matter what.  
> > 
> > Confused here also. For the above scenario, my unmodified layout stays
> > unmodified in the gui. This bug would be a little less confusing if the layout
> > did refresh to show the changes in the other window, since they will be used
> > during execution.
> > 
> > > This is
> > > something that we chose not to address for this release and can be referenced
> > > in Bug #5009 (i.e. Opening two KARS that have the same Workflow, but that have
> > > different report layouts, will make the first layout refresh itself with the
> > > layout from the KAR that was opened most recently.) which still applies.
> > > 
> > >
> > > Can I suggest that this is satisfactory for now and that we should close this
> > > bug ?
> > 
> > I wouldn't close it because I'm guessing incrementing the lsid whenever the
> > report layout is changed is a good way to solve the bug. If we want to add a
> > caveat about not being able to have two copies of the same workflow+report
> > layout pair opened at once then we could maybe postpone the bug.
> 
> To document our conversation from the REAP meeting today, it sounds like the
> more basic problem to all of this is the fact that the KAR only references the
> last report layout that is generated.  We should definitely address this as
> soon as possible. However, since it will take a significant effort and will
> have a fairly wide impact - it may need to be delayed until the next release.

After the REAP meeting today, Matt, Derik, and I discussed some of the issues
related to this bug.  In the course of our discussion the following problem was
described:

Window 1
     Workflow [A]                KAR 0
       Layout [0] 

Window 2
     Workflow [A]                KAR0 -> KAR1
       Layout [0] -> Layout[1]

     Workflow [B]
       Layout [1]
       Layout [2]
       Layout [3]

The following solutions were proposed:

1. LayoutChangedEvent to sync layouts on change via refresh
   -- might be hard, and isn't the right direction

2. Support mulitple layouts per wf
   -- a. gui menu to save layout, menu to switch in RD, menu to
         switch in report viewer, render mutliple reports.
   -- b. could just allow layouts to diverge, association maintained in manager 
         that uses tableau window and layout ID (rather than Worflow LSID)

3. Don't allow the same wf to be opened more than once
   -- would limit the ability of WRM to open multiple runs of same wf.

After some discussion, we decided that solution 2b would provide the best
functionality at this time, and would result in application behaviors that
users could reasonably anticipate.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.