[kepler-dev] [kepler-users] SDF Firing Order

[Christopher Brooks]

I cannot tell a lie, it was I who broke the build 
over the weekend.  However, Edward also broke the build,
so we will both be wearing the "I broke the build" hat.

:-)

There is a ptolemy.actor.lib.FileWriter, which is deprecated
and ptolemy.actor.lib.io.ExpressionWriter is recommended instead.

The reason FileWriter exists is because it predates the code
in ptolemy.actor.io.

In other news, FilePortParameter and FileParameter have a common
interface but don't have a subclass/superclass relationship
so I created the kernel.attributes.FileOrURLAccessor interface
which defines the common interface.  Thus it is possible
to pass around FileOrURLAccessors instead of doing
   if (attribute instanceof FileParameter
       || attribute instanceof FilePortParameter) {

_Christopher

--------

    Dan,
    
    Thanks.  That fixed it.  Sorry, I should have tried another update before
    complaining.
    
    In regard to the other question: I did this a couple of weeks ago.  I know 
   I
    was stopped in ptolemy.actor.lib.io.LineWriter (since the breakpoint is
    still in my list).  I thought I was in a FileWriter (or something like that
   )
    in that package also, but I just checked, and there isn't any, so I must
    have been mistaken.  On looking, there seems to be a FileReader but not a
    FileWriter in Vergil.  Thus, there does not seem to be a problem, and I
    apologize for indicating there is one.  Also what I said about adding littl
   e
    details is thus also not relevant, and I again apologize.  I was clearly
    confused.  I should have taken more time before posting, but it's been a
    busy day, not that that is an excuse.
    
    (I'm pretty sure I'm having order-of-execution problems, though ;-)
    
            -Ken
    
    -----Original Message-----
    From: Dan Higgins [mailto:higgins at nceas.ucsb.edu] 
    Sent: Monday, November 26, 2007 2:29 PM
    To: Kenneth Evans
    Cc: kepler-dev at ecoinformatics.org
    Subject: Re: [kepler-dev] [kepler-users] SDF Firing Order
    
    Hi Ken,
        The error you report was occurring in the Kepler nightly build over 
    the weekend and then disappeared. I assume it was a bug fixed in one of 
    the recent Ptolemy code updates. I suggest you download a new version of 
    the Ptolemy.
    
       
    
    ptolemy.actor.lib.io is a package in Ptolemy, not a class. LineWriter is a
    class in that package and FileWrite extends that class. Any extension runs
    some of the code in the class it is extended from. So Kepler is running
    org.geon.FileWrite whihch inherits most of its methods from LineWriter. You
    can always run the LineWriter actor directly if you do not need the output
    port added in FileWrite.
    
    Dan
    
    
    Kenneth Evans wrote:
    > Hi,
    >
    > As I said before, in Kepler when I use a FileWriter from the list at the
    > left, the Description says org.geon.FileWrite, but the code that is
    running
    > is really in ptolemy.actor.lib.io.  I know this from debugging.  So I am
    > confused.
    >
    > I am trying to avoid writing actors that add little details like "an port
    > that outputs the file path" as I think it leads to more confusion.
    However,
    > that approach doesn't solve the problem of having things work as you want
    > (or need) them to.  Fortunately, Edward fixed the FileWriter, at least th
   e
    > one in ptolemy.actor.lib.io.LineWriter.  It's nicest when it happens that
    > way.
    >
    > I also note that is a nice fix, but I am still having problems with firin
   g
    > order with SDF and now with DDF.
    >
    > Also my ptII build in Eclipse now has errors (after doing a CVS update to
    > get Edward's changes):
    >
    > Severity and Description	Path	Resource	Location
    > Creation Time	Id
    > The method _isCloseToIfNilArrayElement(Token, Token, double) is undefined
    > for the type PublisherTest	ptII/ptolemy/actor/lib	PublisherTest.j
   ava
    > line 219	1196107937711	1944703
    >
    > Severity and Description	Path	Resource	Location
    > Creation Time	Id
    > The method _isCloseToIfNilRecordElement(Token, Token, double) is undefine
   d
    > for the type PublisherTest	ptII/ptolemy/actor/lib	PublisherTest.j
   ava
    > line 224	1196107937711	1944704
    >
    > Severity and Description	Path	Resource	Location
    > Creation Time	Id
    > The method getFileName(FileParameter) in the type FileReader is not
    > applicable for the arguments (FilePortParameter)
    > ptII/ptolemy/codegen/c/actor/lib/io	LineWriter.java	line 93
    > 1196107933539	1944499
    >
    > Do I need to do something?  I do seem to get the fixed FileWriter and hav
   e
    > successfully changed the workflow example I previously sent.
    >
    > Thanks,
    >  
    >         -Ken
    >
    > -----Original Message-----
    > From: Dan Higgins [mailto:higgins at nceas.ucsb.edu] 
    > Sent: Monday, November 26, 2007 12:01 PM
    > To: Edward A. Lee
    > Cc: Kenneth Evans; kepler-dev at ecoinformatics.org
    > Subject: Re: [kepler-dev] [kepler-users] SDF Firing Order
    >
    > Just for anyone's interest, the 'org.geon.fileWrite' class in Kepler 
    > extends ptolemy.actor.lib.io.LineWriter to add an port that outputs the 
    > file path.
    >
    > Dan Higgins
    >
    >
    > _______________________________________________
    > Kepler-dev mailing list
    > Kepler-dev at ecoinformatics.org
    > http://mercury.nceas.ucsb.edu/ecoinformatics/mailman/listinfo/kepler-dev
    >   
    
    
    -- 
    *******************************************************************
    Dan Higgins                                  higgins at nceas.ucsb.edu
    http://www.nceas.ucsb.edu/    Ph: 805-893-5127
    National Center for Ecological Analysis and Synthesis (NCEAS) Marine Scienc
   e
    Building - Room 3405
    Santa Barbara, CA 93195
    *******************************************************************
    
    
    _______________________________________________
    Kepler-dev mailing list
    Kepler-dev at ecoinformatics.org
    http://mercury.nceas.ucsb.edu/ecoinformatics/mailman/listinfo/kepler-dev
--------