[SDM-SPA] Re: [kepler-dev] RFC new directory structure

David Buttler buttler1 at llnl.gov
Fri Mar 19 17:23:54 PST 2004


Hi Chad,
I wanted to throw a few thoughts out on your comments...

> this seems good to me, but it might be better to move the workflows 
> directory under lib.  it's just nicer to have fewer top level 
> directories.
>
There are two goals here that I see
1) minimize clutter, by organizing the resources into appropriate places 
in the CVS repository
2) have a clear, standard location for the different components
Creating a new top-level directory to store all of the workflows seems 
like a better solution from the second point of view.  In my view a lib 
directory contains library code: windows dll's, Linux .so's, Java jar's, 
etc.  Putting things in there that are not those types of files I find 
confusing. 

>>
>
>> 2. demos.htm and ptolemy-index.html should probably be moved out of lib/
>> and into a more appropriate folder, probably into src/.
>
>
> ptolemy-index.html isn't a demo.  it's the startup view for kepler.  
> it gets copied into the ptolemy directory as kepler-index.html.  I 
> think it's fine in lib.
>
Again, I don't think these are really library files.  They are actually 
part of the user interface of Kepler.  It seems that these files should 
be grouped together with all of the documentation that is accessible 
from within the Kepler UI.

>
>>
>> 6. Does anyone know what lib/sample.dat and lib/scew-0.3.1.tar.gz 
>> are? Can we delete them?
>
>
> please do not delete these.  they go with the garp stuff i've been 
> working on.  i can move sample.dat into testdata/garp.  scew is in 
> there so i had access to the version that I know compiles with the 
> garp cpp code.
>
Yeah, we do need to make sure we have all third-party libraries that we 
know work with our code. Since scew is necessary for compiling your garp 
code, it definitely needs to be in the lib directory.  Shouldn't it be 
expanded out from its tarball version under lib/scew-v1.x.y?  Otherwise, 
every time you need to compile you have to decompress the code into a 
temporary directory.  Am I missing something here?

>>
>>
>> The existence of src/exp/ seems a bit questionable.  It seems to stand
>> for "experimental".  Maybe it's time to either make it stable and
>> incorporate it into an existing project, or delete it ...
>
>
> the stuff in exp was was some stuff we were messing around with to 
> extend the type system.  it hasn't been used yet but may be in the 
> future.  please leave it there.
>
Perhaps you could add a file in the exp directory giving it an end of 
life if it hasn't been updated/used by then.  Keeping stuff around that 
may be useful in the future is fine, until it is forgotten about and 
becomes outdated.  Adding a little note that will let future 
incarnations of yourself (or other maintainers) know when the code would 
no longer be useful can really help in future clean ups.


Thanks for the comments,
Dave




More information about the Kepler-dev mailing list