[SDM-SPA] Re: [kepler-dev] moving edu.ncsu to org.sdm.spa

[Xiaowen Xin]

Hi Ilkay,

On Tue, 2004-04-06 at 15:59, Ilkay Altintas wrote:
> Xiaowen,
> 
> I would suggest we do the clean up (other than this
> directory)slower and wait until everybody digests
> Zhengang's changes first.(e.g. I'm waiting to check
> in my kepler/lib clean up/changes due to this morning's
> updates.) But we need to clean this directory.

Ok, that sounds good.  I'm mostly just concerned about this directory
because this one must be identical to what's in the NCSU repository.  So
it would make it much easier for me to sync between them when this one
is cleaned up. The rest should be cleaned as well, but it's not as
urgent for me.

> I checked again and don't have any files to remove from
> the src directory right now as I cleaned it recently.
> Also, the rule in general is not to delete/move any files
> from the kepler cvs unless they are yours or the owner
> of the file asks you to do so. (Or maybe that's the way
> I assume it. ;)
> 
> As I have told in a previous email, gui and cipres are
> directories related to my "experimental at the time" work
> and are associated with some test workflows. They are
> under subdirectories so please don't remove them or include
> them in the SPA release until I go back and make them useful.
> I will remove the cipres directory after I get the command
> line fully functioning.
> WebServiceUsingWSIF.java was removed from NCSU CVS last
> week for the same reason as well. CommandLine actor is
> in the making and not ready for checking in to the SPA
> repository as it is not finalized for release. I will
> check in this file and any coming development myself to
> the SPA cvs when it is ready. Hope this would make it
> easier for you to see which file to include in SPA cvs.
> 
> I don't see the .bak and .orig files you have mentioned
> in the repository.

I must have been hallucinating =)  They were in my local repository, and
CVS didn't put a "?" next to them when I do cvs update.  However, now
that I've deleted them, cvs didn't replace them either.  I don't have a
.cvsignore file in this directory. Hmm ...

WebServiceActor4.java is definitely in there.  Should that be deleted?

> ClustalW_SDSC.java is the original version of ClustalW site
> wrapper that is published as a web service. I don't see any
> use of it to be there right now. Must ask Zhengang if he
> needs it.

Zhengang?  What do you think?

> The other files that were mentioned came from directory
> that was merged today. The directory looks quite messy
> right now but it is still new. Maybe Zhengang is still
> working on it.
> 
> Zhengang: Could you please remove the old and unused files
> when you can? The xml and read me and versions of the
> WebService related actors seem old.
> 
> Ilkay

When we get this sorted out, this directory will be the same as what's
in the NCSU repository except the Kepler repository will have a few
extra experimental files that you're working on.

Another thing is we agreed a few weeks ago that we would have a
org/sdm/spa/util directory for utility files.  So what's currently in
kepler/src/util would ideally go there.  This switch wouldn't be as easy
to make since there's a GEON file that apparently uses both files that
are currently in util/.

Efrat: you're listed as the author for
src/org/geon/OpenDBConnection.java, which is the only non-spa file I
could find that uses the code in util/.  Would it be okay for me to move
what's now in src/util into org/sdm/spa/util/?  Alternatively, we could
move those two files into org/geon/util/.

The reason for this is that since we're already dividing up most of the
source files by organization, we should just divide it all up by
organization.  I think the reason people wanted a util/ directory is so
that it would be a place to put code that would be useful for all
projects.  However, this criteria is hard to determine because most of
the code from one project could potentially be useful in the other
projects.  So I think having a util/ directory as a subdirectory of the
projects makes more sense.  If SPA needed to use something from GEON, we
could import org.geon.*; or org.geon.util.* as an example.  The
distinction here between org.sdm.spa.* and org.sdm.spa.util.* is that
util.* contains non-actor utility code, while all the actors go into
org.sdm.spa.*.

I hope that made sense :)

Xiaowen