[eml-dev] [Bug 5317] New: Data Manager Library: Checks for collapseDelimiter instead of collapseDelimiters

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5317

           Summary: Data Manager Library: Checks for collapseDelimiter
                    instead of collapseDelimiters
           Product: EML
           Version: 2.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: datamanager
        AssignedTo: tao at nceas.ucsb.edu
        ReportedBy: dcosta at lternet.edu
         QAContact: eml-dev at ecoinformatics.org
   Estimated Hours: 0.0


There are two lines in the Data Manager Library source code that contain an
apparent bug. The code checks for an EML element named "collapseDelimiter" when
it should be checking for "collapseDelimiters". These lines are at:

src/org/ecoinformatics/datamanager/parser/eml/Eml200Parser.java, line 1204:

    elementName.equals("collapseDelimiter") && 

src/org/ecoinformatics/datamanager/parser/generic/GenericDataPackageParser.java,
line 1278:

    elementName.equals("collapseDelimiter") && 

In addition, there are a large number of method names, method parameters,
instance variables, and local variables throughout the DML code that are named
'collapseDelimiter' when the more appropriate name for these constructs would
be 'collapseDelimiters'. Since these are only names, they do not affect the
code logic, but it would be good to clean these up and rename them in
accordance with the actual EML element name, 'collapseDelimiters'.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.