[kepler-dev] [Kepler - Bug #6676] External Execution actors generates exception for empty directory

[noreply at nceas.ucsb.edu]

Issue #6676 has been updated by Christopher Brooks.

% Done changed from 0 to 90

This is fixed.

ptolemy.actor.lib.Exec invokes java.lang.Runtime.exec(), which takes as its last argument the directory.  The Javadoc for Runtime.exec() state that if the directory is null, then the current directory of the parent process is used.

I fixed up Exec.java to handle the directory being the empty string, which means that a null gets passed to Runtime.exec().

I updated the documentation for the class and changed ptolemy/actor/lib/test/auto/Exec.xml so that the directory parameter is the empty string, which tickles this bug.

This bug may be closed after someone else confirms that it is fixed.

----------------------------------------
Bug #6676: External Execution actors generates exception for empty directory
https://projects.ecoinformatics.org/ecoinfo/issues/6676#change-21956

* Author: Daniel Crawl
* Status: New
* Priority: Low
* Assignee: Daniel Crawl
* Category: actors
* Target version: 2.5.0
* Bugzilla-Id: 
----------------------------------------
If the directory parameter is empty for the External Execution actor, a NullPointerException is generated:

java.lang.NullPointerException
    at ptolemy.actor.lib.Exec._exec(Exec.java:516)
    at ptolemy.actor.lib.Exec.fire(Exec.java:337)
    at ptolemy.actor.AtomicActor.iterate(AtomicActor.java:496)

It would be better to default to user.dir or throw an exception saying directory must be specified.


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: https://projects.ecoinformatics.org/ecoinfo/my/account

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nceas.ucsb.edu/kepler/pipermail/kepler-dev/attachments/20150302/b720fb0c/attachment.html>