[kepler-dev] [Bug 5655] sdm spa Repeat is a duplicate of a Ptolemy actor

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5655

--- Comment #11 from jianwu <jianwu at sdsc.edu> 2012-09-12 11:00:02 PDT ---
Hi Christopher, you are right. Either setting FiringCountLimit of Const actor
to be 2, or setting blockSize of Repeat actor to be 1 will work. If I just
replace the PN with SDF, the same workflow will throw an exception of Repeat
when I tried to run it. But PN director doesn't throw an exception. That's why
I thought repeat actor doesn't work with PN. Also its class name
(ptolemy.domains.sdf.lib.Repeat) seams it might only work with SDF. :)


After discussion with Dan, I think the best way now is only updating
ptolemy/domains/sdf/lib/Repeat.java by changing its numberOfTimes from
parameter to portparameter. It will cover all the behaviors we need for Repeat.
As for sdm/spa/Repeat.java, since its behavior is a little different when using
SDF (it only output 1). I will comment the code to be deprecated. Old workflows
using this actor can still be opened and run. And since sdm/spa/Repeat.java is
not in the actor tree, new workflows will not use it.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.