[kepler-dev] [Bug 5266] Two empty boxes inside Sinewave actor when in Reporting suite

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266

--- Comment #14 from Sean Riddle <swriddle at gmail.com> ---
(In reply to comment #13)
> Note that the change to ValueIcon was backed out because of bug #5719, see
> http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5719#c2

I have a minor alteration of my earlier patch that I think would fix the
problem. The part of code that generates the label would be changed to:

String truncated = StringUtilities.truncateString(value, width, 1);
LabelFigure label;
if (container instanceof Parameter) {
    label = new LabelFigure(truncated, _labelFont, 1.0,
SwingConstants.SOUTH_WEST);
}
else {
    label = new LabelFigure(name + ": " + truncated, _labelFont, 1.0,
SwingConstants.SOUTH_WEST);
}

This prevents the label from being displayed as 'ParameterType:
ParameterValue'.

The reason that my patch caused all parameter labels to disappear is that
inexplicably all parameters declare _hideName. So simply removing the _hideName
property will make the labels visible. The above refinement to the patch is
only to make the resulting names in line with what they were originally.

Is this an acceptable solution?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nceas.ucsb.edu/kepler/pipermail/kepler-dev/attachments/20121017/2780ed71/attachment.html>