[kepler-dev] [Bug 5266] Two empty boxes inside Sinewave actor when in Reporting suite

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5266

--- Comment #12 from Christopher Brooks <cxh at eecs.berkeley.edu> ---
Sean's patch is below.

The issue here is that this will fix it for one actor.

There are no doubt many other actors that have the same issue.

To close this bug requires fixing the underlying problem, perhaps
with a MoMLFilter.

However, I don't see how we could have filter know that the icon 
should be updated?  

It could be that when this actor was created, it was not created with an _icon
attribute.  One solution would be modify MoMLParser so that if _icon was not
present in the appropriate context then it would be added.



Index: src/ptolemy/actor/lib/Sinewave.xml                                       
===================================================================
--- src/ptolemy/actor/lib/Sinewave.xml  (revision 64734)                        
+++ src/ptolemy/actor/lib/Sinewave.xml  (working copy)                          
@@ -22,6 +22,10 @@
         <property name="_iconDescription"
class="ptolemy.kernel.util.SingletonConfigurableAttribute">                     
             <configure><svg><text x="20" y="20" style="font-size:14;
font-family:SansSerif; fill:blue">Generate a sine wave.</text></svg></c\
onfigure>                                                                       
         </property>                                                            
+        <property name="_icon" class="ptolemy.vergil.icon.ValueIcon">          
+            <property name="_color" class="ptolemy.actor.gui.ColorAttribute"
value="{1.0, 0.0, 0.0, 1.0}">                                   
+            </property>                                                        
+        </property>                                                            
         <property name="_smallIconDescription"
class="ptolemy.kernel.util.SingletonConfigurableAttribute">                     
             <configure>                                                        
       <svg>                                                                    
@@ -75,6 +79,10 @@
       </svg>                                                                   
     </configure>                                                               
         </property>                                                            
+        <property name="_icon" class="ptolemy.vergil.icon.ValueIcon">          
+            <property name="_color" class="ptolemy.actor.gui.ColorAttribute"
value="{1.0, 0.0, 0.0, 1.0}">                                   
+            </property>                                                        
+        </property>                                                            
         <property name="_location" class="ptolemy.kernel.util.Location"
value="[240.0, 100.0]">                                              
         </property>                                                            
     </property>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nceas.ucsb.edu/kepler/pipermail/kepler-dev/attachments/20121001/d73c4235/attachment-0001.html>