[kepler-dev] [Bug 5440] special checkout behavior for hardcoded ptolemy module names

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5440

--- Comment #2 from Derik Barseghian <barseghian at nceas.ucsb.edu> 2012-07-24 18:10:49 PDT ---
That looks similar to the regex I mentioned I didn't use so as not to change
the checkout behavior of ptolemy-kepler-2.2. If you make that change, and
someone tries to use 2.4 to checkout ptolemy-kepler-2.2, it will attempt to
fetch it from the ptII repo and not ours, which is different to how things work
for 2.2.

Instead you'd need something like !PTOLEMY_KEPLER_2_2 &&
startsWith(PTOLEMY_KEPLER). It's debatable whether this is better or worse than
just appending one more fully specified PTOLEMY_KEPLER_2_4 variable.

If you do either of those, please don't close the bug, just push it back. The
right solution is to remove as much behavior hardcoded to module names as
possible.

I'd definitely look around to see what all the other hardcoded uses of
"ptolemy" are for. At 27924 and 27949 I put a lot of the hardcoded "ptolemy"
strings into variables, e.g. at the top of Module.java, so you can search your
workspace for references to those.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.