[kepler-dev] @author tags in duplicated code.

[Christopher Brooks]

The changes look good!
If I have an expression with 4 ports and one is hidden, then canvas
looks much nicer after your changes.

I think we are all set here.

_Christopher

On 11/4/10 12:45 PM, Sven Koehler wrote:
> Thank you for adding the changes.
>
> On 04.11.10 12:07, Edward A. Lee wrote:
>> On 11/4/10 11:26 AM, Christopher Brooks wrote:
>>> Edward may have some input on this. If we don't want this behaviour by
>>> default, then we can set a preference or a parameter in the configuration
>>> that enables it. However, I think we will want this behaviour.
>>
>> I think this is reasonable behavior, so no need for a preference or parameter.
>
> That sounds good. I was only worried about highly customized actors that would also use that layout routine.
>
>>>
>>> However, the code does not seem to work in Ptolemy. If I open up
>>> the attached model, then it appears that the second input takes up space?
>>> I believe that your changes should cause the second input to not take up
>>> space.
>>
>> I don't think the second input is taking up space. By default, the port
>> layout is symmetric, so if there are only two ports, there will be a gap
>> between them.
>
> That is correct. If there are two ports visible there will always be a gap between them in the middle. Additional hidden and unconnected ports would not change that layout. I think that is the
> behavior we also want in Kepler.
>
> Sven

-- 
Christopher Brooks, PMP                       University of California
CHESS Executive Director                      US Mail: 337 Cory Hall
Programmer/Analyst CHESS/Ptolemy/Trust        Berkeley, CA 94720-1774
ph: 510.643.9841 fax:510.642.2718	      (Office: 545Q Cory)
home: (F-Tu) 707.665.0131 cell: 707.332.0670