[kepler-dev] [Bug 5017] ReportLayout LSID and referral list should be maintained

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5017

--- Comment #13 from Derik Barseghian <barseghian at nceas.ucsb.edu> 2010-06-14 13:12:19 PDT ---
(In reply to comment #12)
> (In reply to comment #11)
> > Sounds good. Can you poke around looking for any other similar problems -- e.g.
> > what happens when you have multiple copies of the same report open (same LSID),
> > make changes to one, but switch to the original window and execute that
> > workflow? There exist in the system at that moment two report layouts with the
> > same LSID. Hopefully the right report is used 

I gave the above a try, and what I found (by looking at the generated report)
is that the wrong layout is used (the other window's layout--the one modified
by user-- is used).

>> and has its LSID incremented, and
> > hopefully the other report doesn't lose its changes, will have it's LSID
> > incremented and be saved to prov when that wf is run, etc.
> 
> After testing I have found that what happens in this case, is that when you
> open two copies of the same workflow, select one of them, make changes to one,
> then switch to the original window and execute that workflow, then the LSID for
> the report layout is incremented at that point.  There are no longer 'two'
> report layouts. There is one current layout, and one layout that has (in
> essence) been changed (by running the workflow) but not saved.  If you switch
> to the workflow in either window they will both show the same LSID for the
> report layout.  

How are you looking at the report layout here? I'm confused.

> If you go to that window where the first change was made it
> will always reload the layout from the workflow no matter what.  

Confused here also. For the above scenario, my unmodified layout stays
unmodified in the gui. This bug would be a little less confusing if the layout
did refresh to show the changes in the other window, since they will be used
during execution.

> This is
> something that we chose not to address for this release and can be referenced
> in Bug #5009 (i.e. Opening two KARS that have the same Workflow, but that have
> different report layouts, will make the first layout refresh itself with the
> layout from the KAR that was opened most recently.) which still applies.
> 
>
> Can I suggest that this is satisfactory for now and that we should close this
> bug ?

I wouldn't close it because I'm guessing incrementing the lsid whenever the
report layout is changed is a good way to solve the bug. If we want to add a
caveat about not being able to have two copies of the same workflow+report
layout pair opened at once then we could maybe postpone the bug.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.