[kepler-dev] DirectoryListing actor update

[Jianwu Wang]

Hi Christopher,

     Great! Thanks a lot.

Best wishes

Sincerely yours

Jianwu Wang
jianwu at sdsc.edu
http://users.sdsc.edu/~jianwu/

Assistant Project Scientist
Scientific Workflow Automation Technologies (SWAT) Laboratory
San Diego Supercomputer Center
University of California, San Diego
San Diego, CA, U.S.A.


On 7/14/2010 4:35 PM, Christopher Brooks wrote:
> On 7/14/10 3:41 PM, Jianwu Wang wrote:
>> Hi Christopher,
>>
>> I'm using DirectoryListing actor
>> (ptolemy/src/ptolemy/actor/lib/io/DirectoryListing.java) in one project.
>> It works well but will throw exception when the directory is empty. I
>> think we often need to list some directories without knowing they are
>> empty or not. Sometimes, we want to just ignore the empty directories
>> (namely no output for empty directories), rather than throwing 
>> exceptions.
>> So I extended the class to have one more parameter called
>> 'allowEmptyDir' and its default value is 'false'. If users choose this
>> parameter, the actor will not throw exceptions.
>> I attached the updated class. Please have a look and check it in ptolemy
>> trunk if you think it is feasible. Thanks.
>>
>
> Hi Jianwu,
> Thanks, I merged in your changes to DirectoryListing.  One thing I 
> changed
> was the name of the parameter from allowEmptyDir to allowEmptyDirectory
> as we don't use appreviations in Ptolemy parameter names.
>
> I also created a couple of tests and added you as a contributor to
> that file.
>
> Note that to get the change you will need to update
> kepler/ptolemy/module-info/revision.txt to 58597.
> This should happen automatically, but there is a bug that is not
> updating the ptolemy revision number.
>
> _Christopher
>