[kepler-dev] [Bug 4926] New: Examine Kepler for duplicated Ptolemy code

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=4926

           Summary: Examine Kepler for duplicated Ptolemy code
           Product: Kepler
           Version: 1.x dev
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: berkley at nceas.ucsb.edu
        ReportedBy: cxh at eecs.berkeley.edu
         QAContact: kepler-dev at kepler-project.org


There are a few files in Kepler that have Edward listed as an author.
I suspect that some of these are duplicated code from the Ptolemy II tree.

In the 2.0 release, I searched all the java files for Edward's name and
came up with this list:

bash-3.2$ find . -name "*.java" > /tmp/kj
bash-3.2$ cat /tmp/kj | grep -v ptolemy-8.0 | xargs grep "Edward A. Lee"
./actors-2.0/src/org/sdm/spa/CommandLineExec.java: *         Contributor:
Edward A. Lee
./actors-2.0/src/org/sdm/spa/gui/ShellInterpreter.java: * @author Edward A. Lee
./actors-2.0/src/org/sdm/spa/gui/ShellTextArea.java: * @author John Reekie,
Christopher Hylands, Edward A. Lee
./actors-2.0/src/org/sdm/spa/gui/UserInteractiveShell.java: * This actor code
is adopted from InteractiveShell.java by Edward A. Lee
./ecogrid-2.0/src/ptolemy/vergil/tree/PTree.java: @author Steve Neuendorffer
and Edward A. Lee
./gui-2.0/src/org/kepler/gui/frame/CaseGraphFrame.java: @author Edward A. Lee
./gui-2.0/src/org/kepler/gui/frame/CaseGraphTableau.java: @author  Edward A.
Lee
./gui-2.0/src/org/kepler/gui/frame/KeplerGraphTableau.java: @author  Based on
GraphTableau by Steve Neuendorffer and Edward A. Lee
./gui-2.0/src/org/kepler/gui/frame/MultiCompositeGraphFrame.java: @author
Edward A. Lee, Daniel Crawl
./gui-2.0/src/org/kepler/gui/frame/MultiCompositeTableau.java: @author Edward
A. Lee, Daniel Crawl
./gui-2.0/src/org/kepler/gui/KeplerIconLoader.java: * @author Christopher
Brooks, contributor: Edward A. Lee
./gui-2.0/src/org/kepler/gui/KeplerXMLIcon.java: * @author Steve Neuendorffer,
John Reekie, Contributor: Edward A. Lee
./util-2.0/src/util/LineReader.java: * @author Edward A. Lee, Yuhong Xiong
bash-3.2$ 

Sean Riddle is in the process of fixing the PTree duplication.

To close this bug, each of the files should be examined and ideally, the
original class in Ptolemy be modified and the copy be removed or made much
smaller.

In addition, to close this bug, if Edward is not listed in the history for the
file, then he should be removed as an author and added as a contributor.

-- 
Configure bugmail: http://bugzilla.ecoinformatics.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.