[kepler-dev] [Bug 4282] New: - Duplicate of ptolemy.gui.Top

[bugzilla-daemon at ecoinformatics.org]

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=4282

           Summary: Duplicate of ptolemy.gui.Top
           Product: Kepler
           Version: 1.x dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P4
         Component: build system
        AssignedTo: david.v.welker at gmail.com
        ReportedBy: cxh at eecs.berkeley.edu
         QAContact: kepler-dev at kepler-project.org


I'm creating a bug for this so that it does not get lost and because
this will block bug# 3801.

I don't have the time right now to do a merge between the fix for 3801
and the duplicate code.  I don't think the functionality provided
by the duplicate copy of Top is worth the overhead of a duplicate class
and an entire module (ptII).

David wrote:

> Hi Christopher,
>
>I am happy to consider any alternative methods that you would like to  
>achieve the same result. What I want is a menu item that allows you to  
>invoke the Module Manager from Ptolemy. This allows you to switch from  
>Ptolemy to Kepler and back via the Module Manager without using the  
>build system. This has proven to be highly convenient on more than one  
>occasion.
>
>This functionality probably does not make sense in the context of  
>Ptolemy run without Kepler. That is why it is in the Kepler repository  
>and I have not discussed with you the possibility of integrating it  
>into Ptolemy.
>
>The reason I use Top is so that the option to invoke the Module  
>Manager will exist in every possible context where Ptolemy is run  
>using the Kepler build system. That way, a user exploring Ptolemy  
>functionality always has an easy way to invoke the Module Manager to  
>get back into Kepler.
>
>David


On Aug 5, 2009, at 11:48 AM, Christopher Brooks wrote:

> Hi David,
> It looks like you checked in ptII/src/ptolemy/gui/Top.java,
> which is a duplicate of ptolemy/src/ptolemy/gui/Top.java.
>
> The comment for ptII/src/ptolemy/gui/Top.java is:
>
> r19082 | welker | 2009-06-05 14:41:40 -0700 (Fri, 05 Jun 2009) | 2  
> lines
>
> Adding a Tools-->Module Manager... menu item into ptII so that users  
> who switch to Ptolemy from the Module Manager can go back to Kepler.
>
>
> I think we should remove ptII/src/ptolemy/gui/Top.java because it
> is a duplicate and because the functionality it provides is used very
> little, if at all.
>
> It looks like the ptII module is only present to support the duplicate
> Top class.  Thus, if we get rid of the duplicate Top class, we can
> get rid of the ptII module, which reduces complexity in the module  
> system.
>
> If you would like to come up with a patch to Top.java that provides
> a hook for the menu choice that you would like to add, then we could
> consider that.  One problem is that Top does not use the  
> Configuration,
> so this might entail setting a property and reading it or something.
>
> The reason this comes up is because I'm tracking down the white boxes
> under Windows problem at
> http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3801
> that occurs when the background is set to white.
>
> My fix worked fine in ptolemy outside of Kepler, but failed inside  
> Kepler
> because of the duplicate Top class.
>
> _Christopher