[kepler-dev] Duplicate of ptolemy.gui.Top

Christopher Brooks cxh at eecs.berkeley.edu
Wed Aug 5 11:48:16 PDT 2009


Hi David,
It looks like you checked in ptII/src/ptolemy/gui/Top.java,
which is a duplicate of ptolemy/src/ptolemy/gui/Top.java.

The comment for ptII/src/ptolemy/gui/Top.java is:

r19082 | welker | 2009-06-05 14:41:40 -0700 (Fri, 05 Jun 2009) | 2 lines

Adding a Tools-->Module Manager... menu item into ptII so that users who switch to Ptolemy from the Module Manager can go back to Kepler.


I think we should remove ptII/src/ptolemy/gui/Top.java because it
is a duplicate and because the functionality it provides is used very
little, if at all.

It looks like the ptII module is only present to support the duplicate
Top class.  Thus, if we get rid of the duplicate Top class, we can
get rid of the ptII module, which reduces complexity in the module system.

If you would like to come up with a patch to Top.java that provides
a hook for the menu choice that you would like to add, then we could
consider that.  One problem is that Top does not use the Configuration,
so this might entail setting a property and reading it or something.

The reason this comes up is because I'm tracking down the white boxes
under Windows problem at
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3801
that occurs when the background is set to white.

My fix worked fine in ptolemy outside of Kepler, but failed inside Kepler
because of the duplicate Top class.

_Christopher

-- 
Christopher Brooks (cxh at eecs berkeley edu) University of California
CHESS Executive Director                      US Mail: 337 Cory Hall
Programmer/Analyst CHESS/Ptolemy/Trust        Berkeley, CA 94720-1774
ph: 510.643.9841 fax:510.642.2718	      (Office: 545Q Cory)
home: (F-Tu) 707.665.0131 (W-F) 510.655.5480


More information about the Kepler-dev mailing list