[kepler-dev] util/src/ptolemy/vergil/actor/ActorGraphFrame

[Aaron Schultz]

Hi Christopher,

Yes, having the call to _setBackground() in the repaint methods of 
ActorGraphFrame was a problem because we are setting the background of 
the canvas directly from the KeplerGraphFrame class ( 
_rightComponent.setBackground(BACKGROUND_COLOR); ) and not using the 
ptolemy entity configured background color preference that the 
ActorGraphFrame._setBackground() method uses.  So every time the canvas 
repainted the background color would change back to white after the 
initial color was set to Gray by KeplerGraphFrame.  The only reason for 
setting the canvas background to gray is actually to match the swing tab 
color on MacOSX.  In this l&f I was not able to find a way to adjust the 
background color of the header part of the tab so any other color than 
Gray looks funny on MacOSX.  Probably we just need to figure out how to 
properly use the enitity configured background color preference thingy 
and we could survive without those changes.

Thanks,
Aaron


Christopher Brooks wrote:
> Hi Aaron,
> I'm trying to clear up the files in Kepler that duplicate Ptolemy.
>
> One file is util/src/ptolemy/vergil/actor/ActorGraphFrame.
> The change was:
>
> r16844 | aschultz | 2009-03-04 15:17:11 -0800 (Wed, 04 Mar 2009) | 2 
> lines
>
>    Experiment with KeplerGraphFrame.BACKGROUND_COLOR  and 
> TabManager.BGCOLOR
>    Overriding ActorGraphFrame to avoid _setBackground during repaint
>
>
> The diff is:
> bash-3.2$ diff -rwb util/src/ptolemy/vergil/actor/ActorGraphFrame.java 
> ptolemy/ptolemy/vergil/actor/ActorGraphFrame.java
> 3c3
> <  Copyright (c) 1998-2008 The Regents of the University of California.
> ---
> >  Copyright (c) 1998-2009 The Regents of the University of California.
> 87c87
> <  * @version $Id: ActorGraphFrame.java 52510 2009-02-26 17:52:38Z cxh $
> ---
> >  * @version $Id: ActorGraphFrame.java 53042 2009-04-10 20:31:21Z cxh $
> 376,377c376
> <         // FIXME: This is one of two Kepler specific lines in this code
> <             //_setBackground();
> ---
> >             _setBackground();
> 382,383c381
> <         // FIXME: This is one of two Kepler specific lines in this code
> <             //_setBackground();
> ---
> >             _setBackground();
>
>
> Are these changes required? What happens if we don't have them?
>
> _Christopher