[kepler-dev] text area undo/redo

[ben leinfelder]

After looking at this again, I realized it could be made even more  
generic by creating the UndoableEditListener implementation as a  
regular class (not inner).  That way the ptolemy.actor.gui.TextEditor  
can make use of the same code.  The PythonScript actor seems to makes  
use of the TextEditor when you "Configure Actor" (from the context  
menu).  It would be nice to provide the undo feature there, too.

We could also do something similar with the RExpression actor (but  
instead use the text editor when "Open Actor" is invoked).  Using the  
editor for R would address a few concerns we've heard about the  
current editing window being too small and also demanding window focus  
until the text changes were "committed".
See http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3186 and http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3187

-ben

On Mar 27, 2008, at 11:02 AM, Chad Berkley wrote:

> Sounds like a great change to me.  Christopher, any objections?
>
> chad
>
> ben leinfelder wrote:
>> Hi all,
>> There's been a request to add an "undo" feature when editing  
>> scripts  in the RExpression actor.  See http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3185
>> Locally, I have implemented an UndoableEditListener for the  
>> JTextArea  that is used in ptolemy.gui.Query along with some  
>> supporting inner  classes to facilitate the undoing and redoing of  
>> text edits.  This  change would cascade to all actors when editing  
>> their parameters.   While it seems like a useful feature to  
>> provide, it is in a ptII class  and therefore should probably be  
>> reviewed by the larger community.
>> I've used the standard Ctrl+Z and Ctrl+Y shortcut mappings for  
>> undo  and redo respectively.  And yes, "Ctrl" translates to "open  
>> apple/ command" key on the Mac.
>> Does anyone object to including this change?
>> Thanks,
>> -ben
>> _______________________________________________
>> Kepler-dev mailing list
>> Kepler-dev at ecoinformatics.org
>> http://mercury.nceas.ucsb.edu/ecoinformatics/mailman/listinfo/kepler-dev