[kepler-dev] [Fwd: [Bug 3471] - custom input boxes in actor configuration dialog]

Peter Reutemann fracpete at waikato.ac.nz
Fri Aug 15 23:49:47 PDT 2008

> I folded in your changes, but there is a small issue if I
> try to use your example code in packages outside of ptolemy.gui.
> Any suggestions short of making ptolemy.gui.Query expose
> the inner classes?

I didn't find a quick way either. This whole section of Ptolemy needs
some refactoring, IMO, to make it more flexible. But in order not to
make too many changes (never touch a running system! ;-)), the classes
had to go into the ptolemy.actor.gui and ptolemy.gui package. When one
is developing new modules (and adding more jars to the classpath), it
isn't really a problem, having a few classes in that jar with the
ptolemy.actor.gui/ptolemy.gui package hierarchy.


> ------- Comment #1 from cxh at eecs.berkeley.edu  2008-08-15 11:45 -------
> I folded the Ptolemy changes in to the Ptolemy Tree.
> One issue is that one of the files in the example code from
> http://www.scms.waikato.ac.nz/~fracpete/downloads/ptolemy/custom_query_boxes/examples-classes.zip
> need to be in ptolemy.actor.gui
> I tried to put QueryInputDialogChooser into ptolemy/actor/gui/test,
> but compilation fails because that class uses some package protected inner
> classes in ptolemy.actor.gui.


> The obvious thing is to make the package protected code non-package
> protected.
> There are probably other, more elegant solutions though.

Personally, I'd get rid of all those inner classes in the Query class
and put them in their own class files. And "_notifyListeners" should
be made public. But that's just my 2c.

Cheers, Peter
Peter Reutemann, Dept. of Computer Science, University of Waikato, NZ
http://www.cs.waikato.ac.nz/~fracpete/           Ph. +64 (7) 858-5174

More information about the Kepler-dev mailing list