[kepler-dev] Duplicate Vergil classes

[Edward A. Lee]

Shawn:

The risk here is that if we change IOPortController (which is likely),
Kepler will not see the change.  At a minimum, this means new features
would not be there.  At a maximum, the Kepler build will break...

We really need to be using object-oriented design here...

Wouldn't it make more sense to subclass?

Edward

At 02:19 PM 6/2/2005 -0700, Shawn Bowers wrote:

>Hi Christopher,
>
>Basically, all I wanted to do was to add a menu item (for the time being
>...) to the right-click menu on ports. I also did the same for actors.
>
>I agree that having duplicated code is a bad idea.
>
>Right now, though, I don't have time to extend ptolemy to make this more
>configurable. Also, the use of right click menus for what I am adding
>may not be the final "entry point" into the additions I'm trying to make
>-- so until that is finalized, I just started "hacking" to get it up and
>running for now ;-)
>
>I think that we (speaking for the "kepler" project) need ourselves to
>figure out what GUI extensions we ultimately want and then come up with
>a plan for how to achieve these extensions, including any mechanisms for
>making Vergil more extensible/customizable. Right now, I think we are
>still in the "experimental" and "fleshing it out" stage.
>
>Generally speaking, I think making all right-click menus customizable
>would help a lot ... but that might be a lot of work.
>
>Thanks,
>shawn
>
>
>
>
>Christopher Brooks wrote:
> > Hi Shawn,
> >
> > Is there anyway we can modify the parent class in the Ptolemy II cvs
> > repository so that you extend ptolemy.vergil.actor.IOPortController
> > instead of doing a wholesale copy of the class?
> >
> > If you don't yet have write access to the Ptolemy II cvs repository,
> > I'm more than willing to give it to you so you could add extension
> > points to Ptolemy II.
> >
> > The reason is that we have gotten in to quite a bit of trouble
> > maintenance-wise when we have duplicated code.  The JNI and Single
> > Window code from Thales caused Edward no end of grief when
> > he went to update the copied base classes.
> >
> > Anyway, the up shot is that I'm more than willing to help out
> > if we can avoid duplicate code.
> >
> > _Christopher
>_______________________________________________
>Kepler-dev mailing list
>Kepler-dev at ecoinformatics.org
>http://mercury.nceas.ucsb.edu/ecoinformatics/mailman/listinfo/kepler-dev

------------
Edward A. Lee
Professor, Chair of the EE Division, Associate Chair of EECS
231 Cory Hall, UC Berkeley, Berkeley, CA 94720
phone: 510-642-0253 or 510-642-0455, fax: 510-642-2845
eal at eecs.Berkeley.EDU, http://ptolemy.eecs.berkeley.edu/~eal