[kepler-dev] [Bug 1845] - user input for port type should not be case sensitive

bugzilla-daemon@ecoinformatics.org bugzilla-daemon at ecoinformatics.org
Sun Dec 18 23:43:57 PST 2005


http://bugzilla.ecoinformatics.org/show_bug.cgi?id=1845

cxh at eecs.berkeley.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From cxh at eecs.berkeley.edu  2005-12-18 23:43 -------
I went ahead and fixed this in ptolemy/actor/gui/PortConfigurerDialog.java
by adding a CellFixer class that has a String fixCell(String value) method.
If type cell is invalid, then we call fixCell() with the invalid value
and hopefully get back a fixed value.  If a fixed value is found, we set the
combobox value.

Right now the case insensitivity only works for fundamental types not arrays,
matrices or records.  For example "Double" gets changed to "double", but
"[Double]" does not get changed to "[double]".  To have this work in arrays,
matrices and records would require making the parser case insensitive.  I'm
not so sure that changing the parser is right, it could cause backward 
compatibility issues.

I'm not totally sure that having the type in the combobox be case insensitive
is the correct behaviour.  For example, one of the lamest parts of Windows
is that the so-called file system is case insensitive, yet case preserving.
This causes no end of trouble.  My concern here is that there is a slight chance
we could be preventing the use of user defined types because "STRING" and
"string" could mean two different types.  Anyway, I think this a very remote
possibility, and I myself have had a hard time remembering the capitalization.

Since we've had a combobox here, I've had a much easier time since the choice
is there.  Now that the editable portion of the combobox is case insensitive
and auto correcting, this should be even easier to handle.


More information about the Kepler-dev mailing list